Open AlexSkrypnyk opened 10 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
d8527fd
) 98.72% compared to head (95f5a97
) 98.72%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Release
1.11.0
introduced strict types.With that, the
switchToIFrame(string? $id)
method started to fail on consumer projects usingw3c
=true
because the expected$id
argument has a typestring
instead of expectedint
.According to https://www.w3.org/TR/webdriver/#switch-to-frame, the
$id
is expected to be an integer.This PR updates
string?
withint?
.Note that downstream project
MinkSelenium2Driver
have the same issue propagated after the recent release1.7.0
: https://github.com/minkphp/MinkSelenium2Driver/blob/master/src/Selenium2Driver.php#L431