minkphp / MinkBrowserKitDriver

Symfony2 BrowserKit driver for Mink framework
MIT License
549 stars 80 forks source link

Fix the detection of HTML5 support in the testsuite #148

Closed stof closed 4 years ago

stof commented 4 years ago

The detection relied on detecting the test method added when introducing the feature in symfony/dom-crawler. But as of Symfony 4.4, tests are stripped from the dist archives. An additional detection based on a new method added in later Symfony version is now used to filter out the false positives (not detecting 4.4 and newer as being <3.3).

This code will be cleaned when dropping support for old Symfony versions, but I want to tag a release before doing that.