Closed Daniel-Marynicz closed 2 years ago
Hello :wave: I think it could be great to have this MR merged and a new version tagged, any plan to do so ? Willing to give a hand if it needs to
👍 once CI green
Thanks @Daniel-Marynicz !
371.10 failed but this have in logs "Done. Your build exited with 0." https://travis-ci.org/github/minkphp/MinkBrowserKitDriver/jobs/741646049
Should SYMFONY_VERSION='^4'
be added to the TravisCI matrix?
Should
SYMFONY_VERSION='^4'
be added to the TravisCI matrix?
@longwave , looks valid. I've added that in my review of this PR. Thank you.
Once this PR merged, is there any reason to keep https://github.com/FriendsOfBehat/MinkBrowserKitDriver @pamil?
UP ! Is there anyone who can do something to have this PR approved and merged ? Please 🙏. Symfony is out for one year and a half and we still are not able to use this package with it... Thank you very much for your work.
Any update on this one?
Closing in favor of #161 and #162 (and older PRs about the CI setup)
This should probably be reconciled with https://github.com/minkphp/MinkBrowserKitDriver/pull/142 which is trying to do the same thing.