search

minkphp / MinkBrowserKitDriver

Symfony2 BrowserKit driver for Mink framework
MIT License
549 stars 80 forks source link

Move to GitHub Actions and bump minimum PHP to 5.4 #158

Closed alexpott closed 3 years ago

alexpott commented 3 years ago

Still got some things to fix... https://github.com/alexpott/MinkBrowserKitDriver/actions/runs/1311190433

stof commented 3 years ago

@alexpott the failure reported for Behat\Mink\Exception\UnsupportedDriverActionException: Behat\Mink\Driver\BrowserKitDriver supports clicking on links and submit or reset buttons only. But "div" provided seems to indicate that your change in driver-testsuite regarding UnsupportedDriverTestCase is broken, as that's precisely what should not happen thanks to that

stof commented 3 years ago

and other failures are because you need to migrate from @expectedException to expectException in ErrorHandlingTest

alexpott commented 3 years ago

Github actions are now all green - https://github.com/alexpott/MinkBrowserKitDriver/actions/runs/1311363955

stof commented 3 years ago

@alexpott if you have the time, there's still other driver repos that haven't been migrated to github actions.

alexpott commented 3 years ago

It's green https://github.com/alexpott/MinkBrowserKitDriver/actions/runs/1325275564

stof commented 3 years ago

@alexpott can you squash your commits ?