search

minkphp / MinkBrowserKitDriver

Symfony2 BrowserKit driver for Mink framework
MIT License
550 stars 80 forks source link

Fix (by removing) an outdated docblock type hint #166

Closed mpdude closed 1 year ago

mpdude commented 1 year ago

This is necessary to make Psalm checks pass at https://github.com/FriendsOfBehat/SymfonyExtension/pull/195.

codecov[bot] commented 1 year ago

Codecov Report

Merging #166 (5d3d2b2) into master (1852736) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #166   +/-   ##
=========================================
  Coverage     98.24%   98.24%           
  Complexity      113      113           
=========================================
  Files             1        1           
  Lines           285      285           
=========================================
  Hits            280      280           
  Misses            5        5
Impacted Files Coverage Δ
src/BrowserKitDriver.php 98.24% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

mpdude commented 1 year ago

@stof do you think you could cut a bugfix release including this? I have a pending PR in one of the friends-of-Behat repos that cannot pass builds due to Psalm errors solved here.

🙏🏻