search

minkphp / MinkBundle

Mink library integration bundle for Symfony2
MIT License
60 stars 18 forks source link

V1.5.x #49

Closed 66Ton99 closed 11 years ago

stof commented 11 years ago

do we really need a 1.4.X and a 1.5.x branch in the bundle ?

stof commented 11 years ago

IMO, we should have the supported version in master. there is no need to maintain 3 branches with the same code in it.

66Ton99 commented 11 years ago

Yes, 1.5.x it is too mach, I will remove it, but 1.4.X is pointed to mink 1.4.x and old drivers

stof commented 11 years ago

@66Ton99 1.4 drivers are compatible with 1.5 drivers (composer will handle selecting the right driver version for Mink versions). For instance, the MinkExtension configuring Mink when using it in Behat does not need 2 branches: https://github.com/Behat/MinkExtension/blob/master/composer.json

66Ton99 commented 11 years ago

@stof no thanks, if do not fix versions all the time would be some problems and errors. Good example current build!

stof commented 11 years ago

@66Ton99 the configuration is BC between Mink 1.4 and Mink 1.5. So maintaining 2 branches if the bundle is duplicating maintenance work. Thus, you are maintaining 3 branches whereas Mink master and Mink 1.5 are the same thing

66Ton99 commented 11 years ago

@stof v1.5.x was removed