minkphp / MinkBundle

Mink library integration bundle for Symfony2
MIT License
60 stars 18 forks source link

Mink should be a singleton service #60

Open elnur opened 10 years ago

elnur commented 10 years ago

Currently Mink is a prototype service and I've lost several hours figuring out why the hell I'm getting different sessions whenever I ask Mink to give me the default session.

It turned out that since Mink is a prototype service, I was getting a new instance of Mink each time I asked it from the container.

Since Mink itself is just a fancy factory, it should be a singleton.

redstar504 commented 10 years ago

:+1: