minkphp / MinkGoutteDriver

Goutte driver for Mink framework
MIT License
300 stars 52 forks source link

Allow Symfony <2.3 #15

Closed benja-M-1 closed 11 years ago

stof commented 11 years ago

this is wrong. You are now forcing to use a 2.3-dev tag, which does not match any stable version of Symfony (and never will)

benja-M-1 commented 11 years ago

Arg yes you are absolutely right :( @everzet you should revert this

Btw, even if this question is related to some other Behat repositories, I wonder why we have to add an upper constraint in other repositories to Symfony components? Is that really necessary? Because when Symfony 2.2 will be released and the devs for 2.3 will start we would have to change again the composer.json file

stof commented 11 years ago

We have an upper constraint because we don't know the future of any Symfony release (without an upper constraint, you would tell Composer that a tag of the library done know will also work with Symfony 3.0 and 4.0 and so on as tags cannot be changed later). And 2.1.* which was used previous has an upper bound (it is an aliasfor >=2.1,<2.2-dev)

And there is no need to revert as I pushed a fix

everzet commented 11 years ago

Thanks @stof :kiss:

stof commented 11 years ago

btw, once Symfony 2.3 is released, we will be able to allow all 2.* releases as the BC will be guaranted by the Symfony team in any subsequent minor release (unless there is a really good reason for breaking)

benja-M-1 commented 11 years ago

Ok, thanks