Convert Guzzle\Http\Message\Header instances to arrays

minkphp / MinkGoutteDriver

Goutte driver for Mink framework

MIT License

299 stars 52 forks source link

Convert Guzzle\Http\Message\Header instances to arrays #21

Closed davedevelopment closed 11 years ago

davedevelopment commented 11 years ago

See also fabpot/Goutte#107

benji07 commented 11 years ago

:+1:

everzet commented 11 years ago

Why it fails for 5.5?

benji07 commented 11 years ago

It fail because of a deprecated call inside

curl_setopt_array(): The usage of the @filename API for file uploading is deprecated. Please use the CURLFile class instead NodeElement class

davelens commented 11 years ago

Came here to do pretty much the same pull request. :)

:+1:

stof commented 11 years ago

This should be fixed in Goutte itself. Goutte should not put Guzzle Header objects in the BrowserKit response. It is not respecting the BrowserKit contract.

benji07 commented 11 years ago

This is fix in https://github.com/fabpot/Goutte/commit/e91360db7e91fa302ea21050bf85a7c4c1423b5f

davedevelopment commented 11 years ago

It is fixed in fabpot/Goutte@e91360d, but this class overrides the createResponse method?

stof commented 11 years ago

IMO, the override of the method should be refactored to call the parent logic to avoid duplication.

davedevelopment commented 11 years ago

@stof probably, I just assumed it was overridden for good reason. If I get chance later I'll take a look.