search

minkphp / MinkGoutteDriver

Goutte driver for Mink framework
MIT License
300 stars 52 forks source link

Requesting a new tag #46

Closed tractorcow closed 10 years ago

tractorcow commented 10 years ago

If this module is to be upgraded to mink 1.6 as a dependency, could we please have a new tag prior to this update being made? Currently we depend on this version for a mink 1.5 configuration in our project.

See https://github.com/Behat/MinkSelenium2Driver/issues/153 for the problem we encountered on the MinkSelenium2Driver.

See https://github.com/Behat/Mink/issues/548 also. :)

aik099 commented 10 years ago

PR's created. Ready for review.

stof commented 10 years ago

the official statement is that you should either use the existing stable version of Mink and its drivers, or the dev versions of all the Mink stack.

The current code of the MinkGoutteDriver requires the dev version of the MinkBrowserKitDriver for instance. It is not compatible with the old stable version because of refactoring being done in both drivers

tractorcow commented 10 years ago

Yes, I agree with this reasoning. :) (although, only because I now no longer rely on using Mink 1.5, admittedly).