search

minkphp / MinkGoutteDriver

Goutte driver for Mink framework
MIT License
300 stars 52 forks source link

Updated Goutte dependency to friendsofphp/goutte #54

Closed acirtautas closed 9 years ago

acirtautas commented 9 years ago

Fix for issue found after goutte migration to friendsofphp/goutte

stof commented 9 years ago

This is wrong. the github repo has been moved, but the composer package has not been renamed. friendsofphp/goutte does not exist: https://github.com/FriendsOfPHP/Goutte/blob/65ab61eae03d670b93a9044ad2328eb81aa1bde5/composer.json#L2

acirtautas commented 9 years ago

Yes @stof it looks wrong now,

but it started failing on my dev system using composer with message:

Failed to download fabpot/goutte from dist: The "https://api.github.com/repos/fabpot/Goutte/zipball/b12c3f7ec68d8814b50444cfe142fd0a056557f9" file could not be downloaded: failed to open stream: Connection timed out

Then composer wanted to clone Goutte from source and failed again:

Failed to clone git@github.com:fabpot/Goutte.git via git, https, ssh protocols, aborting.

Maybe it was just a temporary issue with github.

aik099 commented 9 years ago

If a repo was moved on GitHub, then you can still clone using old url. That's why Packagist (used by Composer) still works. However I personally update repo url on Packagist to new location to avoid any such issues.

stof commented 9 years ago

Packagist has updated the repo location. However, your lock file might have the older dist URLs in it, and Github does not redirect archive URLs for renamed repos. The next time you will update Goutte during a composer update, your lock file will get the new URL.

@fabpot could you fork Goutte to your personal account again, as you did for some other repos, so that old download URLs still work ?