search

minkphp / MinkGoutteDriver

Goutte driver for Mink framework
MIT License
299 stars 52 forks source link

Next version to include updated dependencies? #63

Closed davidbarratt closed 9 years ago

davidbarratt commented 9 years ago

What is the next stable release version number that will include the updated dependencies? https://github.com/minkphp/MinkGoutteDriver/commit/44563f46fa99fef2df50ce083048094828e068b7

I'm asking for: https://www.drupal.org/node/2493911#comment-10096820

aik099 commented 9 years ago

Unfortunately not before Guzzle 6 or Goutte 3 will fix issue with cookie handling. You can see failed build here: https://travis-ci.org/minkphp/MinkGoutteDriver

I'm not such one (Guzzle or Goutte) has a bug.

davidbarratt commented 9 years ago

@aik099,

I'm sorry, what I meant is not when, but what version. Is the next version to include the dependencies going to be 1.1.2, 1.3.0, 2.0.0, etc. ?

aik099 commented 9 years ago

Theoretically dependency change should be considered as reason to have 1.3.0, but I'm not 100% certain.

davidbarratt commented 9 years ago

@aik099,

Thanks! I updated our ticket to reflect that: https://www.drupal.org/node/2493911#comment-10101510

aik099 commented 9 years ago

Ah that's why you've asked about version :smile: . Then I'm afraid your suggestion for ^1.3.0 version won't get you master branch of this repo.

To make this happen a branch alias in composer.json needs to be changed to 1.3.x-dev. @stof am I right in assuming, that next release would be 1.3.0?

davidbarratt commented 9 years ago

@aik099,

A branch alias in your composer.json or Drupal's?

aik099 commented 9 years ago

This repo one. Because we're talking about this repo version usage on Drupal's side.

davidbarratt commented 9 years ago

@aik099,

Well now that you know what we're trying to do, any help would be greatly appreciated. :)

aik099 commented 9 years ago

Based on Drupal task title you're updating to latest version of everything. Any specific need or just for fun?

davidbarratt commented 9 years ago

@aik099,

We're trying to update Guzzle to the latest stable release to satisfy this issue: https://www.drupal.org/node/2400407

davidbarratt commented 9 years ago

@aik099,

With only 15 critical issues remaining, we are getting close to a release candidate of Drupal 8 https://www.drupal.org/project/issues/search/drupal?status[0]=1&status[1]=13&status[2]=8&status[3]=14&status[4]=4&priorities[0]=400&categories[0]=1&categories[1]=2&categories[2]=5&version[0]=8.x

aik099 commented 9 years ago

OK. We'll waiting for @stof then to know the next version number of MinkGoutteDriver.

stof commented 9 years ago

1.2.0 has been released