search

minkphp / MinkGoutteDriver

Goutte driver for Mink framework
MIT License
299 stars 52 forks source link

Compatibility with Goutte 4.x #85

Closed lstrojny closed 2 years ago

lstrojny commented 4 years ago

ATM 3.1 is supported maximally, would be cool if 4.x would be supported

aik099 commented 4 years ago

What is ATM, surely not a cashing machine?

You're welcome to send a PR to add support for Goutte 4.x.

francislavoie commented 4 years ago

ATM means "at the moment".

I'm also running into issues with this, I'm trying to update Guzzle to v7, but since this requires Goutte 3.x which still uses Guzzle (and requires v6), there's a dependency conflict.

aik099 commented 4 years ago

PR's are welcome.

sbusemann commented 3 years ago

@aik099 can I sponsor the update - how much would it be?

aik099 commented 3 years ago

@sbusemann , I'm not using Goutte myself to understand how to properly upgrade it without BC breaks. However, if you can find a developer willing to submit a PR, then you surely can pay him/her for the effort.

I'll try to review the PR to my best Goutte understanding.

Thank you.

stof commented 3 years ago

Goutte v4 does not implement a custom way to manage the HTTP basic auth. It is now a normal BrowserKit implementation (the best proof is the code of the goutte client, which does not contain anything else than an extends clause). This means that Goutte v4 should be used with BrowserKitDriver directly.