Rewrite the window name tests to avoid forcing a pattern

minkphp / MinkSelenium2Driver

Selenium2 (webdriver) driver for Mink framework

MIT License

507 stars 163 forks source link

Rewrite the window name tests to avoid forcing a pattern #294

Closed stof closed 6 years ago

stof commented 6 years ago

Selenium defines the window name as a opaque string, so each browser is free to use anything they want. And this changed over time, causing the UUID regex to break even for browsers using a UUID in the past (Chrome adds more things around the UUID for instance).

aik099 commented 6 years ago

OK.

stof commented 6 years ago

this makes these tests pass when running them locally against chrome and firefox