Closed oleg-andreyev closed 5 years ago
@aik099 @stof
@aik099 after you will be okay with changes, I'll squash changes into one commit.
Merging, thanks @oleg-andreyev .
I don't have permission on Packagist (to update releases list) / GitHub (to create releases). This is where @stof should take on the lead. Also release date in CHANGELOG.md
should be updated by @stof to represent actual date, when release will happen.
We were depending on "behat/mink-selenium2-driver": "1.3.x-dev",
in our composer.json, now... 🔥
We'll update to ~1
or ~1.3
or dev-master
, so just an FYI, as we might not be the only ones.
@aik099 if you could tag the 1.4.0 release on GitHub, Packagist might take care of itself (if it's set to auto-update).
@greg-1-anderson , unfortunately I can't (see https://github.com/minkphp/MinkSelenium2Driver/pull/311#issuecomment-527083719).
I was hoping that @stof had corresponding permissions on Packagist/GitHub or that maybe @everzet can grant us both with such permissions for all Mink repositories (main one, test suite and all drivers).
Related discussion: #313 (doesn't mean we should change anything on our side).
there is no change to do on Packagist. It picks the tag automatically.
there is no change to do on Packagist. It picks the tag automatically.
I could have guessed that since 1.3.x
version was removed from Packagist automatically.
@aik099 @stof so it's matter of pushing 1.4.0, so we need only to push this tag and create release on GitHub or it's also automated?
@oleg-andreyev , we need to create new release on GitHub side with correct notes and that will trigger tag creation and that will be picked up by Packagist.
It would still be very good to actually push the tag in git, or make the tag on github as a release. Packagist will automatically update, but as of right now, there is no 1.4.0 release.
c.f. #269
1.4.0 / 2019-08-28
Bug fixes:
change
JS event upon input value is change (fixes auto-complete control testing in Google Chrome)clickOnElement
method wasn't working when Selenium 3 with Firefox GeckoDriver was usedChanges:
New features:
getDesiredCapabilities
method for fetching current desired capabilitiesTestsuite:
Misc:
setDesiredCapabilities
method combines default capabilities with user provided onessetDesiredCapabilities
method will throw an exception, when used on a started sessioncloses #284