minkphp / MinkSelenium2Driver

Selenium2 (webdriver) driver for Mink framework
MIT License
507 stars 163 forks source link

New Release #311

Closed oleg-andreyev closed 5 years ago

oleg-andreyev commented 5 years ago

1.4.0 / 2019-08-28

Bug fixes:

Changes:

New features:

Testsuite:

Misc:

closes #284

oleg-andreyev commented 5 years ago

@aik099 @stof

oleg-andreyev commented 5 years ago

@aik099 after you will be okay with changes, I'll squash changes into one commit.

aik099 commented 5 years ago

Merging, thanks @oleg-andreyev .

I don't have permission on Packagist (to update releases list) / GitHub (to create releases). This is where @stof should take on the lead. Also release date in CHANGELOG.md should be updated by @stof to represent actual date, when release will happen.

timmillwood commented 5 years ago

We were depending on "behat/mink-selenium2-driver": "1.3.x-dev", in our composer.json, now... 🔥

We'll update to ~1 or ~1.3 or dev-master, so just an FYI, as we might not be the only ones.

greg-1-anderson commented 5 years ago

@aik099 if you could tag the 1.4.0 release on GitHub, Packagist might take care of itself (if it's set to auto-update).

aik099 commented 5 years ago

@greg-1-anderson , unfortunately I can't (see https://github.com/minkphp/MinkSelenium2Driver/pull/311#issuecomment-527083719).

I was hoping that @stof had corresponding permissions on Packagist/GitHub or that maybe @everzet can grant us both with such permissions for all Mink repositories (main one, test suite and all drivers).

aik099 commented 5 years ago

Related discussion: #313 (doesn't mean we should change anything on our side).

stof commented 5 years ago

there is no change to do on Packagist. It picks the tag automatically.

aik099 commented 5 years ago

there is no change to do on Packagist. It picks the tag automatically.

I could have guessed that since 1.3.x version was removed from Packagist automatically.

oleg-andreyev commented 5 years ago

@aik099 @stof so it's matter of pushing 1.4.0, so we need only to push this tag and create release on GitHub or it's also automated?

aik099 commented 5 years ago

@oleg-andreyev , we need to create new release on GitHub side with correct notes and that will trigger tag creation and that will be picked up by Packagist.

ryanaslett commented 5 years ago

It would still be very good to actually push the tag in git, or make the tag on github as a release. Packagist will automatically update, but as of right now, there is no 1.4.0 release.

greg-1-anderson commented 5 years ago

c.f. #269