Closed alexpott closed 3 years ago
Or can you let me know if there is something blocking a release that I can help with - I'm more than happy to.
I guess the most relevant thing right now is to get the builds working again. Due to changes on Travis CI it no longer suites our needs (at least IMO) and we need to move to GitHub Actions.
As for the next steps, that block the release I have no idea. We'd better ( cc @stof ) create an umbrella task listing all the blocking issues. This way, if all tests will pass, we'll release the current release and think about dropping (or not dropping) support for an older PHP version to ease up adding support for newer PHP versions as discussed in https://github.com/minkphp/Mink/issues/787 .
@aik099 @stof whilst I understand wishing to fix your CI looking at the difference between v1.4.0 and master - https://github.com/minkphp/MinkSelenium2Driver/compare/v1.4.0...master - there's not a lot there - it's mostly PHP 8.1 fixes and not doing a release makes it harder for your dependencies to test on PHP 8.1 and, therefore, make their own code compatible.
It would be really great if you could re-consider the order of priorities here as not having a MinkSelenium2Driver release that doesn't trigger deprecations on PHP 8.1.
Here's the work to get github actions largely working and testing all the PHPs... #339
@stof now that we have testing on PHP 8.1 are there any other blockers to releasing v1.4.1? As there's no minimum PHP version change I think this can be a patch release.
1.5.0 is now released
Thanks @aik099 and @stof for all the maintainer work on this code. I was wondering if a v1.4.1 release could be made for PHP 8.1 compatibility?