search

minkphp / MinkSelenium2Driver

Selenium2 (webdriver) driver for Mink framework
MIT License
507 stars 163 forks source link

Pure refactoring - use nowdoc instead of heredoc #355

Closed mvorisek closed 2 years ago

mvorisek commented 2 years ago

not supported by PHP 7.2

stof commented 2 years ago

the issue is not about nowdoc vs heredoc, but about the indented variant of them.

mvorisek commented 2 years ago

the issue is not about nowdoc vs heredoc, but about the indented variant of them.

I find nowdoc safer as no variables interpolation is possibles, but the changed LOC is low when not reindent, thus I will submit it as a part of another PR