search

minkphp / MinkSelenium2Driver

Selenium2 (webdriver) driver for Mink framework
MIT License
508 stars 163 forks source link

Add proper handling of non-started sessions #370

Closed stof closed 1 year ago

stof commented 1 year ago

This case now throws a DriverException instead of triggering a PHP Fatal Error.

Closes https://github.com/minkphp/Mink/issues/679

This was not caught by phpstan initially due to the incomplete type on the wdSession property.

codecov[bot] commented 1 year ago

Codecov Report

Merging #370 (703b9ca) into master (76c50a0) will increase coverage by 0.25%. The diff coverage is 92.50%.

@@             Coverage Diff              @@
##             master     #370      +/-   ##
============================================
+ Coverage     89.72%   89.97%   +0.25%     
- Complexity      157      158       +1     
============================================
  Files             1        1              
  Lines           467      469       +2     
============================================
+ Hits            419      422       +3     
+ Misses           48       47       -1
Impacted Files Coverage Δ
src/Selenium2Driver.php 89.97% <92.50%> (+0.25%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more