minkphp / MinkSelenium2Driver

Selenium2 (webdriver) driver for Mink framework
MIT License
507 stars 163 forks source link

Add types for method parameters #371

Closed stof closed 1 year ago

stof commented 1 year ago

Now that the Mink DriverInterface has parameter types (thanks to https://github.com/minkphp/Mink/pull/856), we can add them in the child class.

codecov[bot] commented 1 year ago

Codecov Report

Merging #371 (374413c) into master (037675d) will increase coverage by 0.95%. The diff coverage is 97.77%.

@@             Coverage Diff              @@
##             master     #371      +/-   ##
============================================
+ Coverage     89.02%   89.97%   +0.95%     
+ Complexity      315      168     -147     
============================================
  Files             2        1       -1     
  Lines           875      469     -406     
============================================
- Hits            779      422     -357     
+ Misses           96       47      -49     
Impacted Files Coverage Δ
src/Selenium2Driver.php 89.97% <97.77%> (+0.74%) :arrow_up:

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more