minkphp / MinkZombieDriver

Zombie.js driver for Mink framework
41 stars 49 forks source link

Fixed the retrieval of the value of options #106

Closed stof closed 10 years ago

stof commented 10 years ago

The DOM property should be used rather than getting the attribute directly, to support properly elements which have a fallback behavior when their value attribute is missing (option elements are using their text in such case).

This fixes the test failure for options without values. refs #98

aik099 commented 10 years ago

Do we have a test that covers this?

stof commented 10 years ago

yes. See the failure number 5 in the issue #98

aik099 commented 10 years ago

I guess you can mention failure numbers in other two PR's you've made today as well.

stof commented 10 years ago

already done :)