search

minkphp / MinkZombieDriver

Zombie.js driver for Mink framework
41 stars 49 forks source link

Add a dependency on PHP's sockets extension. #124

Closed bartfeenstra closed 9 years ago

bartfeenstra commented 9 years ago

Behat\Mink\Driver\NodeJS\Connection calls socket_create, which is part of PHP's sockets extension. Because Composer does not check for this dependency, this code can be executed and fail on systems that don't have the extension.

aik099 commented 9 years ago

:+1: . I guess every previous ZombieDriver usage was having this extension installed.

bartfeenstra commented 9 years ago

That failure seems unrelated... Does it look familiar to you?

aik099 commented 9 years ago

Failure seems to be a random one because it failed only for PHP 5.3 and error comes from Zombie that isn't PHP-related. I've restarted that particular Travis job and I guess it will pass.

aik099 commented 9 years ago

Now all is green, as I've expected.

bartfeenstra commented 9 years ago

Bump.

stof commented 9 years ago

thanks

bartfeenstra commented 9 years ago

That was quick. Thanks!