Upgrade the authentication logic for Zombie 3

minkphp / MinkZombieDriver

Zombie.js driver for Mink framework

41 stars 49 forks source link

Upgrade the authentication logic for Zombie 3 #129

Closed stof closed 9 years ago

stof commented 9 years ago

This fixes #128. I chose the easy way for now by forcing to use Zombie 3.

It would not be a lot more difficult to support both 2.x and 3.x at the same time as we are not affected by other BC breaks (at least as far as our testsuite is catching). What would be our choice on this @aik099 ?

stof commented 9 years ago

note that if we bump the zombie dependency, I need to also update the readme as it mentions the zombie version.

aik099 commented 9 years ago

Looking at changes you've made it won't be super hard to prevent BC break. We just do: browser. authenticate ? browser.authenticate().... : browser.on('authenticate', ..... We can also extend browser object itself and just always use some kind of unified code.

stof commented 9 years ago

updated