Throw exception, when options are changed on running server

minkphp / MinkZombieDriver

Zombie.js driver for Mink framework

41 stars 49 forks source link

Throw exception, when options are changed on running server #157

Closed aik099 closed 8 years ago

aik099 commented 8 years ago

The Behat\Mink\Driver\NodeJS\Server class have bunch of methods for setting options of the NodeJS server, that will be created. There is only one problem with them: when used on already running server they:

have no effect
developer thinks all worked fine

Proposing to throw an exception, when attempt to change running server options is made.

stof commented 8 years ago

looks good to me

aik099 commented 8 years ago

Nice, will send a PR soon. Please look on other issues I've reported for Zombie.

aik099 commented 8 years ago

PR created, ready for review.