search

minkphp / MinkZombieDriver

Zombie.js driver for Mink framework
41 stars 49 forks source link

Changing host or port should regenerate server code #158

Closed aik099 closed 8 years ago

aik099 commented 8 years ago

The Behat\Mink\Driver\NodeJS\Server::createTemporaryServer uses following options of the server:

Currently on change of nodeModulesPath causes temporary server code to be regenerated.

Propose to regenerate temporary server code also on host and port option change.

Separate issue (see #157) is created to prevent calling these methods on already running server, that would have no effect.

stof commented 8 years ago

See https://github.com/minkphp/MinkZombieDriver/issues/161 for my proposal to solve it in a much better way (the case of a running server still need to be prevented even in my proposal)

aik099 commented 8 years ago

Agreed that creating ENV-based server instead of PHP variable patching is better way.