search

minkphp / MinkZombieDriver

Zombie.js driver for Mink framework
41 stars 49 forks source link

Don't create a temporary server when setting the node modules path #163

Closed stof closed 8 years ago

stof commented 8 years ago

Forcing to create a temporary server is breaking the support of custom server scripts (for people wanting to do it for whatever reason). Rebuilding the server is also useless now that the script does not uses replacements but environment variables.

Closes #160.

This would break the usage of the setter for people using their own Server implementation not updated to stop using replacements, but this should not be common (and I wouldn't consider it as a supported usage). People using ZombieDriver must be using the ZombieServer class anyway, so no BC break for them

aik099 commented 8 years ago

Failed tests.

stof commented 8 years ago

yeah, ServerTest is a bit weird, and it was testing this behavior.

I removed the assertion on the replacement (as I broke this small case, as explained above, even though it does not impact the usage of the driver thanks to the previous PR), and I also updated the tests to better test the Server class regarding the temporary server (allowing to test the deprecated API btw)

aik099 commented 8 years ago

Good.

stof commented 8 years ago

This PR is the blocker for the release of this driver. All other (non-deprecated) drivers have been released