search

minkphp / MinkZombieDriver

Zombie.js driver for Mink framework
41 stars 49 forks source link

The PHP 7 tests failing on Travis CI #182

Closed aik099 closed 2 years ago

aik099 commented 7 years ago

The PHP 7 tests failing on Travis CI:

https://travis-ci.org/minkphp/MinkZombieDriver/builds/244589944

I guess this is because PHPUnit 6 is picked by Travis CI, which doesn't have PHPUnit_Framework_TestCase class.

Since we can't have test suite compatible with both PHPUnit 5 and PHPUnit 6 the best approach would be to indicating in .travis.yml to use PHPUnit 5 all the time.

Same should be done for other driver repos and main repo because they would fail eventually.

rpkamp commented 5 years ago

PHPUnit is installed through symfony/phpunit-bridge. This is currently pinned to ^4.0 in minkphp/driver-testsuite. This version of symfony/phpunit-bridge is explictly incompatible with PHPUnit 5 and lower (composer conflicts).

So I think the right approach here is not to make everything use PHPUnit 5, but update the tests to be compatible with (at least) PHPUnit 6.

aik099 commented 5 years ago

Sure. Let's do this if that won't increase minimum supported PHP version by driver / test suite itself.

rpkamp commented 5 years ago

I started too, but the saw there already is a PR for this, and the tests are green on that one: https://github.com/minkphp/MinkZombieDriver/pull/189 :slightly_smiling_face: