search

minkphp / MinkZombieDriver

Zombie.js driver for Mink framework
41 stars 49 forks source link

Fix all tests for PHP 7.x #189

Closed beoboo closed 3 years ago

beoboo commented 5 years ago

Tests should be run with phpunit and not simple-phpunit (because PHP 7-1 uses PHPUnit 5.7).

aik099 commented 5 years ago

Fixing https://travis-ci.org/minkphp/MinkZombieDriver/jobs/502013256 would require locking to non-latest PHPUnit version for PHP 7.x version.

To fix https://travis-ci.org/minkphp/MinkZombieDriver/jobs/502013252 you need to do use latest PHPUnit version compatible with PHP 5.5.

aik099 commented 5 years ago

The https://travis-ci.org/minkphp/MinkZombieDriver/jobs/502148600 build of PHP 5.3 has failed due incorrect NODEJS path.

aik099 commented 5 years ago

@beoboo , good job indeed. Just finish latest comments I've mentioned (about composer.json changes).

I have no idea why PHP 5.3 build fails that bad. I've tried to to run test locally using PHP 5.3.29 and Zombie 6.1.4.

beoboo commented 5 years ago

I think PHP 5.3 might be failing because the script is not able to run

vendor/bin/mink-test-server > /dev/null 2>&1 &`

(or better it exists without showing any error). I'll try removing the output redirects to debug it.

beoboo commented 5 years ago

I created a wrong #190, #189 is the last correct one that fixed all tests.

aik099 commented 5 years ago

You do create lots of commits (I guess no other way to test Travis CI) and I do get an e-mail for every of them.

When you're ready for review just post a comment.

beoboo commented 5 years ago

Ready for review 😄.

aik099 commented 5 years ago

Looks good to me. @stof , what you think?

rpkamp commented 5 years ago

This looks awesome, and would bring mink one step closer to be compatible with Symfony 4 (see https://github.com/minkphp/Mink/issues/757).

Anything I can do to help this move forward?

Einenlum commented 5 years ago

Any news?

rpkamp commented 5 years ago

@aik099 can we move forward on this please? Moving forward to allow using Symfony 4 is an important next step for Mink I think, since all developers that use Symfony flex that install Mink now will get an error.

aik099 commented 5 years ago

@rpkamp , still waiting for @stof to review.

stmllr commented 5 years ago

I applied this PR and raised composer requirement "symfony/process": "~2.1|~3.0|~4.0". My tests are running fine with Symfony process 4.3.3.

Sidlegionair commented 4 years ago

@stof Any updates on this?

stof commented 3 years ago

Closing in favor of #196