search

minkphp / MinkZombieDriver

Zombie.js driver for Mink framework
41 stars 49 forks source link

Handle non-ascii characters in url #194

Open kolesar-andras opened 4 years ago

kolesar-andras commented 4 years ago

Closes #193

stof commented 2 years ago

I think the issue is the fact that the URL is injected into the evaluated JS code without properly escaping the string. Instead of using "$url", it should use $urlEscaped (without the double quotes around it), created as $urlEscaped = json_encode($url), as done in other methods of the driver.