search

minkphp / driver-testsuite

Functional testsuite for Mink drivers
MIT License
8 stars 29 forks source link

Test basic auth (username+password) in URLs #15

Closed cweiske closed 2 years ago

stof commented 6 years ago

@aik099 only after the merge

stof commented 5 years ago

Which of the existing drivers already support that, and which one will need a patch ?

cweiske commented 4 years ago

I started this PR here because @aik099 asked in https://github.com/minkphp/MinkGoutteDriver/pull/77 to provide this request so that we'd see which drivers currently support it.

stof commented 4 years ago

@aik099 once merged, yes.

cweiske commented 2 years ago

Will this go any further? Otherwise I'll close this PR and delete my repository.

aik099 commented 2 years ago

Merging, thanks @cweiske .

aik099 commented 2 years ago

@cweiske ,

Ah, now, once tests are executed I can clearly see, that they fail with newer PHPUnit versions:

Next steps:

  1. import Yoast\PHPUnitPolyfills\Polyfills\AssertStringContains class into relevant test case file
  2. add use AssertStringContains in that test case file
  3. use assertStringContainsString instead of assertContains
cweiske commented 2 years ago

@aik099 done

aik099 commented 2 years ago

Nice, the Zombie and BrowserKit drivers support basic auth in URL out of the box.

stof commented 2 years ago

@cweiske This test fails in the Selenium2Driver CI, probably due to not isolating tests enough