search

minkphp / driver-testsuite

Functional testsuite for Mink drivers
MIT License
8 stars 29 forks source link

Fix condition for safePageWait in GeneralTest::testAdvancedForm #35

Closed robertfausk closed 4 years ago

robertfausk commented 5 years ago

...cause both pages have a title and we are on the new/submitted page if title is "Advanced form save".

Form page: https://github.com/minkphp/driver-testsuite/blob/d208035ccc5eaf4f1def0299a1979c1851a9a0fb/web-fixtures/advanced_form.html#L4 Submitted page: https://github.com/minkphp/driver-testsuite/blob/d208035ccc5eaf4f1def0299a1979c1851a9a0fb/web-fixtures/advanced_form_post.php#L4

Edit: Added file preview.

aik099 commented 5 years ago

Makes sense.

I don't recall, that we'd had any issues with previous implementation though (e.g. redirect after submit, that wasn't made wasn't causing test to fail).