search

minkphp / driver-testsuite

Functional testsuite for Mink drivers
MIT License
8 stars 29 forks source link

Dropping support of 5.3 and forcing phpunit < 8 #37

Closed oleg-andreyev closed 5 years ago

oleg-andreyev commented 5 years ago

Single PR which addresses #34 and #33

aik099 commented 5 years ago

As action plan in #34 wasn't confirmed by maintainers you're removing PHP 5.3 support on your own risk.

oleg-andreyev commented 5 years ago

@aik099 I'm willing to help with support MinkPHP / Selenium2Driver, but I cannot do it without maintainers support and because of it, all PRs are hung in unknown status.

/cc @stof

oleg-andreyev commented 5 years ago

@stof I have successful build using my fix-master-build branch in MinkSelenium2Driver https://travis-ci.org/minkphp/MinkSelenium2Driver/builds/549205452

oleg-andreyev commented 5 years ago

@stof

aik099 commented 5 years ago

Merging. Thank you @oleg-andreyev . Apologies for a delay.

stof commented 5 years ago

Dropping PHP 5.3 support in the driver-testsuite while drivers haven't dropped it yet looks like a weird process to me. This is what makes the CI red for BrowserKitDriver for instance...

stof commented 5 years ago

Also, this PR is not forcing PHPUnit < 8 contrary to what it announces.

oleg-andreyev commented 5 years ago

@stof it's quite complicated to sync changes across all repos, so it would be great to integrate "dependent builds", so when this repo changes it will trigger all dependent repos.

http://eng.rightscale.com/2015/04/27/dependent-builds-in-travis.html

Now about BrowserKit, I'll take a look at build and we'll ensure that we're forcing phpunit < 8

aik099 commented 5 years ago

Also, this PR is not forcing PHPUnit < 8 contrary to what it announces.

@stof , that was original PR content. Although over course of commits we somehow (I'm totally lost now in all Composer packages and their version/dependency variety) managed to figure out that depending on different symfony/phpunit-bridge version should get desired effect.

Not sure if that alone did the trick or we've updated driver repos in parallel as well (there is no associated PR for driver repos for me to determine that).

@oleg-andreyev , could you please explain why merged code looks like it looks now? I can't find our discussion about these changes this this PR.

stof commented 5 years ago

But that means that the process is easy here: the driver-testsuite must wait for all drivers to drop PHP 5.3 before dropping it. For now, I reverted the PHP version bump here, to let me work on having green builds for drivers to release them. And from what I saw on BrowserKitDriver, the PHPUnit 8 issue happens when using version 4.4.x-dev of the bridge (in the DEPENDENCIES=dev job) so bumping the min version won't help (it might help to avoid issues in a --prefer-lowest job though, as older releases of the bridge are broken by a change in PHPUnit's policy regarding old branches on github). Existing stable versions of the bridge never install PHPUnit 8.