search

minkphp / driver-testsuite

Functional testsuite for Mink drivers
MIT License
8 stars 29 forks source link

Fix basic auth test: use assertContainsString #49

Closed cweiske closed 2 years ago

cweiske commented 2 years ago

Related: https://github.com/minkphp/driver-testsuite/pull/15

cweiske commented 2 years ago

Because that file already uses the assertContainsString method. No need for me to do it again.

aik099 commented 2 years ago

haven't used polyfill trait for older PHPUnit versions, which will result in the Fatal Error on some PHPUnit versions

I see now. Thank you.

you've used the assertContainsString method (not sure if it exists) instead of assertStringContainsString, which will result in the Fatal Error all the time

@cweiske , Still the issue.

cweiske commented 2 years ago

Oh, sorry. Fixed now.

aik099 commented 2 years ago

Merging, thanks @cweiske .