search

minkphp / driver-testsuite

Functional testsuite for Mink drivers
MIT License
8 stars 29 forks source link

Fix tests for Selenium 3.x #60

Closed mvorisek closed 8 months ago

mvorisek commented 2 years ago

needed for https://github.com/minkphp/MinkSelenium2Driver/pull/354

mvorisek commented 2 years ago

PR with test fixes is RTM, I will then submit fixes for the driver itself

uuf6429 commented 8 months ago

@aik099 @mvorisek considering we are using the same test-suite for selenium 2, 3 and 4 in webdriver-classic-driver, I don't think this PR is relevant any more (or at least, it won't really fix selenium3-specific test problems).

aik099 commented 8 months ago

@uuf6429 , as for fixing the part I agree (the driver-specific PRs for almost all issues were created and mentioned in the https://github.com/minkphp/MinkSelenium2Driver/pull/383).

I'm not closing this PR yet, because I'm curious what was the reasoning behind key code adding in the tests.

aik099 commented 8 months ago

Closing, because selenium 2 driver code was changed instead (PRs not merged yet) to make tests pass.