search

minkphp / driver-testsuite

Functional testsuite for Mink drivers
MIT License
8 stars 29 forks source link

Test setting of text fields with numeric values #80

Closed xurizaemon closed 1 year ago

xurizaemon commented 1 year ago

Ref https://github.com/minkphp/MinkBrowserKitDriver/pull/173

xurizaemon commented 1 year ago

We can add coverage in minkphp/driver-testsuite so behaviour of numeric $element->setValue(123) is specified, as was done for other input types in https://github.com/minkphp/driver-testsuite/pull/74. Would that be useful?

I opened this thinking that introducing such a constraint might impact existing test coverage in other projects, and that adding test coverage would let us specify whether it's permitted or not.

But ... minkphp/driver-testsuite#80 currently fails PHPStan checks because setValue() accepts only string|bool|array, and if it means changing the documented inputs of Behat\Mink\Element\NodeElement::setValue(), that's a bigger change I'm not confident of proposing 😄 especially as it's been documented that way for nine years.

For that reason I'll close this.