search

minkphp / driver-testsuite

Functional testsuite for Mink drivers
MIT License
8 stars 28 forks source link

Added tests to verify, that iframe switching by an id works #87

Closed aik099 closed 6 months ago

aik099 commented 7 months ago

Existing tests only cover iframe switching by name. This PR adds these tests:

  1. frame switching by an id;
  2. frame switching by an index.

See https://github.com/minkphp/Mink/issues/866 (PR 2 of 4)

The PhpStan correctly reports this, but I can't fix it due to the problem described in the above-mentioned issue.

Error: Parameter #1 $name of method Behat\Mink\Session::switchToIFrame() expects string|null, int|string given.
aik099 commented 6 months ago

The PR now tests frame switching by an ID (added code) in addition to frame switching an a name (existing code).

aik099 commented 6 months ago

@stof , both requested changes have been made. Ready for another review.

aik099 commented 6 months ago

the failed CI should be solved by rebasing on the latest master thanks to #90

Rebased. Merging now.