search

minkphp / phpunit-mink

Library for using Mink in PHPUnit tests. Supports session sharing between tests in a test case.
BSD 3-Clause "New" or "Revised" License
70 stars 20 forks source link

Provide access to the "SelectorsHandler" used during the Mink's Session construction #129

Closed aik099 closed 7 months ago

aik099 commented 7 months ago

The only road blocker for QA-Tools library before it will be Mink 2.0 compatible is inability to inject customer selectors handler into the Mink created sessions (see https://github.com/qa-tools/qa-tools/issues/104).

To resolve this issue we need to:

  1. create a SelectorsHandler once per test suite
  2. use that selectors handler in the SessionFactory during session creation
  3. make that selectors handler accessible from the BrowserTestCase test case class
aik099 commented 7 months ago

I've decided to take an alternative approach to this. Instead of making SelectorsHandler available for QA-Tools to inject a new selectors handler the https://github.com/qa-tools/qa-tools/pull/222 removes the need to inject anything in the first place.