search

minkphp / phpunit-mink

Library for using Mink in PHPUnit tests. Supports session sharing between tests in a test case.
BSD 3-Clause "New" or "Revised" License
70 stars 20 forks source link

Invoke "BrowserTestCase::onTestSuiteEnded" method only for executed tests #130

Closed aik099 closed 7 months ago

aik099 commented 7 months ago

The BrowserTestCase::onTestSuiteEnded event was also invoked for excluded tests. This happened because tests for iteration were retrieved from the TestSuite::tests method (which returns all tests and even those, that won't be executed).

Instead, interaction should be made through the TestSuite class object itself (as PHPUnit does). This has been fixed by this PR.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.58%. Comparing base (fe5911c) to head (1c7a6e2).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #130 +/- ## ============================================ - Coverage 86.27% 82.58% -3.70% Complexity 330 330 ============================================ Files 30 30 Lines 867 867 ============================================ - Hits 748 716 -32 - Misses 119 151 +32 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.