search

minkphp / webdriver-classic-driver

Mink driver for the W3C WebDriver Classic protocol
MIT License
3 stars 5 forks source link

Connect this driver to the "Behat\MinkExtension" project #15

Closed aik099 closed 8 months ago

aik099 commented 9 months ago

Currently, there is no way to use this driver in the Behat, because there is no corresponding driver in the https://github.com/Behat/MinkExtension/tree/master/src/Behat/MinkExtension/ServiceContainer/Driver .

The driver key would be webdriver-classic instead of selenium2. The current Selenium2 driver could be used as a starting point.

@uuf6429 , please submit a PR to that repo.

uuf6429 commented 9 months ago

@aik099 / @stof just one question, out of curiosity, why are the driver factories in the behat/mink-extension package, instead of each individual driver package?

If I wanted to use these drivers in a modular way, e.g. "in my own framework", I'd also want to use DriverFactoryInterface (and not initialize the drivers directly) - so that interface is probably not really MinkExtension-specific.

aik099 commented 9 months ago

I've just noticed a huge banner on top of https://github.com/Behat/MinkExtension that recommends using https://github.com/FriendsOfBehat/MinkExtension instead.

@stof , isn't there a way to have a single repo?

uuf6429 commented 9 months ago

On that topic, I think it would make sense to have a roadmap for Behat (and Mink).

stof commented 8 months ago

Those driver factories are specific to the MinkExtension package because they are extension points to let other Behat extensions support additional drivers in the MinkExtension configuration. Those factories are not generic factories meant to support any usage.

For all official drivers, we have factories directly in the MinkExtension itself. But the SymfonyExtension is also providing an additional driver factory using the BrowserKitDriver configured with a KernelBrowser using the Symfony kernel.

@aik099 there is a single repo for the MinkExtension now: the FriendsOfBehat one. We moved extensions outside the Behat organization. I thought we had archived the repository but apparently we only marked it as abandoned on packagist.

uuf6429 commented 8 months ago

@stof

there is a single repo for the MinkExtension now: the FriendsOfBehat one

FriendsOfBehat/MinkExtension is a bit of a mess:

  1. it lacks proper documentation/readme, referring to the old/to-be-archived one instead (even though it has its own doc dir)
  2. it claims not take any updates/features/improvements, unless they are compatibility bugfixes
  3. looking at the code, it could do with some updating, but the previous point makes that unlikely to happen

I'll open a PR nonetheless, but this situation, (on top of the lack of feedback in Behat PRs/issues), doesn't inspire much confidence in Behat/Mink TBH.

@aik099 I'm closing this issue since it doesn't have anything to do with webdriver-classic-driver anymore.