Open uuf6429 opened 6 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 82.24%. Comparing base (
3b449c5
) to head (3466441
). Report is 12 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Isn't the "usage" section missing some information about the need to run a Webdriver server ?
@stof
Isn't the "usage" section missing some information about the need to run a Webdriver server ?
How would you propose that would look like? It feels like it might be a repeat of the testing section "use docker and this image OR download and run selenium, chrome-driver, chrome etc".
@uuf6429 people wanting to use the driver might not read the Testing
section (which might even belong to a CONTRIBUTING.md
file instead)
@uuf6429 people wanting to use the driver might not read the
Testing
section (which might even belong to aCONTRIBUTING.md
file instead)
@stof I'm not saying we shouldn't have that, I was just asking how it would look like, and/or if it's fine to copy it over from the testing section.
We could copy it from the Testing section (maybe with a sentence mentioning that you could also run the browser-specific driver directly instead of Selenium depending on your use case)
Fixes #4.