minkphp / webdriver-classic-driver

Mink driver for the W3C WebDriver Classic protocol
MIT License
3 stars 5 forks source link

Improve readme #19

Open uuf6429 opened 6 months ago

uuf6429 commented 6 months ago

Fixes #4.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.24%. Comparing base (3b449c5) to head (3466441). Report is 12 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #19 +/- ## ============================================ - Coverage 83.54% 82.24% -1.31% Complexity 191 191 ============================================ Files 1 1 Lines 468 473 +5 ============================================ - Hits 391 389 -2 - Misses 77 84 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

stof commented 6 months ago

Isn't the "usage" section missing some information about the need to run a Webdriver server ?

uuf6429 commented 6 months ago

@stof

Isn't the "usage" section missing some information about the need to run a Webdriver server ?

How would you propose that would look like? It feels like it might be a repeat of the testing section "use docker and this image OR download and run selenium, chrome-driver, chrome etc".

stof commented 6 months ago

@uuf6429 people wanting to use the driver might not read the Testing section (which might even belong to a CONTRIBUTING.md file instead)

uuf6429 commented 6 months ago

@uuf6429 people wanting to use the driver might not read the Testing section (which might even belong to a CONTRIBUTING.md file instead)

@stof I'm not saying we shouldn't have that, I was just asking how it would look like, and/or if it's fine to copy it over from the testing section.

stof commented 6 months ago

We could copy it from the Testing section (maybe with a sentence mentioning that you could also run the browser-specific driver directly instead of Selenium depending on your use case)