minkphp / webdriver-classic-driver

Mink driver for the W3C WebDriver Classic protocol
MIT License
3 stars 5 forks source link

Don't iterate windows, when already at correct window #24

Closed aik099 closed 7 months ago

aik099 commented 7 months ago

I've noticed, that when trying to resize/maximize the current window several calls are made to the Selenium server to verify if we're at the right window. IMO they're unnecessary because we're surely at the correct window already.

P.S. There is no test to verify, that resizing/maximizing non-current window works.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.65%. Comparing base (8a540d9) to head (97d00f8).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #24 +/- ## ============================================ + Coverage 83.54% 83.65% +0.10% - Complexity 191 192 +1 ============================================ Files 1 1 Lines 468 471 +3 ============================================ + Hits 391 394 +3 Misses 77 77 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.