Simplify custom tests - Githubissues

minkphp / webdriver-classic-driver

Mink driver for the W3C WebDriver Classic protocol

MIT License

3 stars 5 forks source link

Simplify custom tests #43

Closed uuf6429 closed 3 weeks ago

uuf6429 commented 3 weeks ago

The base TestCase from driver-testsuite has some disadvantages:

it tends to require some additional boilerplate for most driver-specific tests
it's a bit unclear/convoluted for simple test scenarios
in principle, tests requiring mink/getSession() are probably misplaced and should exist in the driver testsuite when you think about it

With that in mind, I came up with a simple base TestCase class that copies some of the functionality of the original one. In my opinion, we should make helper traits out of the original one, which driver authors could use - but that's a bit off topic.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.61%. Comparing base (9afb55f) to head (4e6615f).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #43 +/- ## ============================================ + Coverage 84.21% 84.61% +0.40% Complexity 194 194 ============================================ Files 1 1 Lines 494 494 ============================================ + Hits 416 418 +2 + Misses 78 76 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

stof commented 3 weeks ago

For custom tests covering driver-specific configuration settings, using the driver directly makes sense (and is what we already do in a bunch of tests of other drivers). However, for the shared tests, writing them as functional tests using the high-level API of Mink makes sense IMO