minnojs / minno-dashboard

Client-side of minno’s study management and authoring tool
1 stars 2 forks source link

image down-scaling in the preview/editor pane #103

Open pinusm opened 7 years ago

pinusm commented 7 years ago

When images are selected, they are not scaled to fit the current view. This works ok for smaller-than-current images, but larger ones mess with the layout of the dashboard. I'm not saying scaling-down is a must (but it will be nice-to-have), just that maintaining layout consistency is. Scaling-up is probably a bad idea, as it will make the images look distorted more often than not.

scale images

There's also a probably related issue I stumbled upon when trying to see just how distorted the small image in the example below would be, and that's the the down-scaling should be responsive/dynamic to the current zoom level (See what happens at the 250% zoom level).

scale images2

eladzlot commented 7 years ago

Fixed. will be available on the next version.

https://github.com/ProjectImplicit/researchDashboard/commit/659ac783b38449cc9ebb5bbfad91c5aee59800e8

On Wed, Jun 7, 2017 at 3:24 PM, Michael Pinus notifications@github.com wrote:

When images are selected, they are not scaled to fit the current view. This works ok for smaller-than-current images, but larger ones mess with the layout of the dashboard. I'm not saying scaling-down is a must (but it will be nice-to-have), just that maintaining layout consistency is. Scaling-up is probably a bad idea, as it will make the images look distorted more often than not.

[image: scale images] https://user-images.githubusercontent.com/10765331/26877799-c328e0f2-4b93-11e7-8b70-15add60f3815.gif

There's also a probably related issue I stumbled upon when trying to see just how distorted the small image in the example below would be, and that's the the down-scaling should be responsive/dynamic to the current zoom level (See what happens at the 250% zoom level).

[image: scale images2] https://user-images.githubusercontent.com/10765331/26878128-052987ee-4b95-11e7-8bd5-98fc8827341f.gif

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ProjectImplicit/researchDashboard/issues/103, or mute the thread https://github.com/notifications/unsubscribe-auth/AByZF1CEi_Za5z0F3RlmZtAsQ0iPzQOcks5sBpZ5gaJpZM4NyoEo .