minnojs / minno-dashboard

Client-side of minno’s study management and authoring tool
1 stars 2 forks source link

bug(UI): dropdowns can drop out of view #60

Open eladzlot opened 7 years ago

eladzlot commented 7 years ago

maybe right isn't working correctly?

screen shot 2016-11-09 at 11 15 57 am
eladzlot commented 7 years ago

@baranan It is not trivial to make the dropdown automatically choose the correct direction to open. Is the "resize sidebar" option (#42) enough to solve this for us, or should we invest in automating this?

baranan commented 7 years ago

1) Can you add a default width that will still show all the buttons on small screens? In other words, in my view the problem is that the widths of the section do not dynamically change to allow a reasonable view in small screens. 2) In another issue ( https://github.com/ProjectImplicit/researchDashboard/issues/62), I suggested using two rows of buttons. That might also help prevent this problem.

On Thu, Nov 10, 2016 at 10:57 AM, eladzlot notifications@github.com wrote:

@baranan https://github.com/baranan It is not trivial to make the dropdown automatically choose the correct direction to open. Is the "resize sidebar" option enough to solve this for us, or should we invest in automating this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ProjectImplicit/researchDashboard/issues/60#issuecomment-259635500, or mute the thread https://github.com/notifications/unsubscribe-auth/AED1VxOF_k9go7us_c5cMPSmFzKC9Lwdks5q8tyEgaJpZM4KuVDb .

eladzlot commented 7 years ago

You can see that the buttons are already in two rows in the screen cap, so that won't help. The problem is not a function of screen size, but of sidebar size. I don't want the sidebar any bigger by default so that we have the maximum possible editor frame. The proper solution is to have the dropdown open to the right instead of to the left in smaller screens (Though it doesn't look as good). or maybe I can play some more with the layout, like so:

screen shot 2016-11-10 at 11 20 06 am

baranan commented 7 years ago

I'm not sure what the image is showing. It doesn't look good, right? Perhaps on small screens you can use smaller font for the left pane?