Closed Alexcolom closed 6 years ago
Hi Alexander, I have accepted your first commit, fixing it up a little. A few notes for next time:
git log
to see examples.ImagePe32 | ImageElf32
). But conceptually that doesn't make sense, an image cannot be both an ELF and a PE image. The purpose of this enum was to define the image format, where only exactly one applies. Maybe on a separate pull request thread for that change we can discuss what you're trying to do here.Thank you again for submitting this change and going through the revision. It is much appreciated, and I hope there are more to come. I'm sorry I took so long to respond, and will try to be more prompt next time.
Hi Evan, Please see the changes that I made so that I could move on. -Alexander