Develop1

[Alexcolom]

To compile *.S files in MSVC , I execute the following command: cl /E "%(FullPath)" /I include /DWINNT /DASM | as -o "%(Filename).obj" But when the compiler encounters a comment delimiter # in an empty string, the compiler generates an error. To can also correct this error for MSVC by deleting an empty line before the comment delimiter #. --Olexandr.

[evangreen]

Hi Olexandr, This approach looks good to me. A couple of comments, as usual:

• For next time, a more descriptive pull request name than "Develop1" might be appropriate. Something that describes at a high level what you're trying to pull in. In this case, the subject line of the commit would work well. I think it's possible to name pull requests, right?
• Can you squash your merge and two commits together into a single commit? You can use git rebase -i, which is a very powerful command, in order to rewrite your history. This allows you to squash commits together, and edit the commit message. If you ever do it wrong, you can use git reflog to find your commit before the rebase attempt, and git reset --hard to get back to it.
• I don't love the inconsistency of commenting here. The comments are fairly verbose, how about we just change it to:

     .long   0x0                         # null descriptor, it is unused.

Then we can remove the next line of comment-only entirely.

[Alexcolom]

Hi Evan, Yes, completely agree with you about the combine comments in one line before the delimiter. Can I do it myself or do you want to do it yourself?