search

minoca / os

Minoca operating system
Other
2.71k stars 232 forks source link

BopEfiGetDebugDevice in dbgser.c doesn't iterate through the list of handles. #149

Closed jparris closed 6 years ago

jparris commented 6 years ago

Hi, I was reading through dbgser.c and noticed that the for loop always uses Handles[0] instead of walking through the array of handles returned by LocateHandleBuffer.

    //
    // Loop through all the handles until one is successfully configured.
    //

    for (HandleIndex = 0; HandleIndex < HandleCount; HandleIndex += 1) {

        //
        // Get the serial I/O protocol.
        //

        EfiStatus = BopEfiHandleProtocol(Handles[0],   <---- Should be Handles[HandlesIndex]
                                         &BoEfiSerialIoProtocolGuid,
evangreen commented 6 years ago

Good catch. Thanks for pointing that out.