search

minoca / os

Minoca operating system
Other
2.71k stars 231 forks source link

[MACOS] Fix two compiler errors by changing syntax. #166

Closed vinhig closed 2 years ago

vinhig commented 2 years ago

Diving into the code and trying to compile it with pre-built tools binaries gave me two different errors:

os/lib/rtl/base/build/../fp2int.c:1326:20: error: bitwise negation of a boolean expression; did you mean logical negation? [-Werror,-Wbool-operation]

Fixed by applying a little if

os/apps/swiss/uos/../swlib/pattern.c:906:42: error: adding 'int' to a string does not append to the string [-Werror,-Wstring-plus-int]

Fixed by replacing a pointer offset by pointer of an array element

So before implementing bigger features, I wanted to make sure it compiles on my machine. Here is the change. Enjoy!

evangreen commented 2 years ago

Thanks Vincent. Would you be willing to sign the CAA here? Then I can review and pull your change.

vinhig commented 2 years ago

I've just signed it. We can proceed to the next part.

evangreen commented 2 years ago

Thanks! I left one minor comment, with that resolved this should be good to merge.

vinhig commented 2 years ago

Code has been modified according to review.

evangreen commented 2 years ago

Looks good. I squashed the commits, added some more description to the commit message, and pushed this as 6750d31e02d4f6f745a88caa4dd05f2f672b8832. Thanks!