search

minodisk / bigquery-runner

An extension to query BigQuery directly and view the results in VSCode.
https://marketplace.visualstudio.com/items?itemName=minodisk.bigquery-runner
Apache License 2.0
44 stars 8 forks source link

README: fix broken json in example config #53

Closed fabridamicelli closed 9 months ago

fabridamicelli commented 9 months ago

Current example config is broken json, so one cannot copy-paste it and get it working. This PR fixes json making it work out-of-the box

minodisk commented 9 months ago

@fabridamicelli

Thanks for the PR. But the README.md you fixed is generative, so I need you to edit the template, README.md.ejs. Otherwise your contribution history will be lost from the file.

fabridamicelli commented 9 months ago

@minodisk Thanks for the swift reaction.

I just fixed the commit with the change only in README.md.ejs. Hope that works?

minodisk commented 9 months ago

@fabridamicelli Thank you! Perfect!

minodisk commented 9 months ago

@fabridamicelli Published as v1.21.12 🎉

fabridamicelli commented 9 months ago

@fabridamicelli Published as v1.21.12 🎉

Great!