search

minosworld / minos

MINOS: Multimodal Indoor Simulator
MIT License
201 stars 33 forks source link

Small fixes #26

Closed johny-c closed 6 years ago

johny-c commented 6 years ago

1) Regarding the README.md: At least on my system (Ubuntu 16.04) it needs to be nvm install node instead of nvm install. Unfortunately, surprisingly many things can go wrong during the installation of node and npm.

2) I added two __init__.py files, so that minos and gym_minos can be recognized as packages (for instance by PyCharm)

3) I added an entry in .gitignore to ignore .python-version files (for virtual environments).

msavva commented 6 years ago

Thanks @johny-c for helping to improve minos!

johny-c commented 6 years ago

Hi @kvas7andy , I think this happens, because of the order the packages are found in the path. gym has to be found before minos.

kvas7andy commented 6 years ago

@johny-c related to this issue, I think this file is unnecessary, as we already have "__init__.py" files in root directory, minos and in gym/gym_minos, that should be enough to use modules from python.