search

minreiseah / pe

0 stars 0 forks source link

Naming error in Model UML diagram #20

Open minreiseah opened 7 months ago

minreiseah commented 7 months ago

image.png

image.png

The UML uses "UniqueEmployeeList" but the github gist at https://github.com/AY2324S2-CS2103T-T15-4/tp/blob/v1.4/src/main/java/seedu/address/model/ModelManager.java actually uses "filteredEmployees".

This might make it difficult for a new contributor to navigate the Model.

nus-pe-bot commented 7 months ago

Team's Response

The tester seems to be claiming that ModelManager in the code uses filteredEmployees, which would be correct as per the screenshot of the code, while the UML diagram shows that it is using UniqueEmployeeList.

However, the UniqueEmployeeList is connected to TaskMasterPro instead of to ModelManager. TaskMasterPro is the class that consists of the UniqueEmployeeList instead.

The ModelManager in the UML diagram is instead connected directly to Employee and it is indicated that it is filtered.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]